Review Request 109001: Avoid using std::string where possible

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109001/#review27728
-----------------------------------------------------------

Ship it!


Thanks for the patch (and the explenation!), just tested that still all unit tests pass.

- Andreas Cord-Landwehr


On Feb. 17, 2013, 11:10 p.m., Thiago Macieira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109001/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 11:10 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Description
> -------
> 
> QString::toStdString() is more expensive than QString::toLatin1()
> since it must go through the "codec for C strings" codec and it must
> use std::string. Without C++11, it has no move semantics.
> 
> 
> Diffs
> -----
> 
>   RocsCore/Data.cpp c0c3fe8 
>   RocsCore/DataStructure.cpp 6277081 
>   RocsCore/DataStructures/LinkedList/ListStructure.cpp f510d66 
>   RocsCore/LoadSave/Plugins/gmlFileFormat/CMakeLists.txt 651f89b 
>   RocsCore/Modifiers/ValueModifier.cpp 90e26bb 
>   RocsCore/Pointer.cpp f1f171f 
>   VisualEditor/Scene/DataItem.cpp 8be7700 
>   VisualEditor/Scene/PointerItem.cpp 8efe0ec 
> 
> Diff: http://git.reviewboard.kde.org/r/109001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thiago Macieira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130219/a3effbb5/attachment.html>