Review Request 108806: kig: Use standard cmake module to find boost_python

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108806/#review27032
-----------------------------------------------------------


This actually doesn't work

-- Looking for trunc - found
CMake Warning at /home/kdeunstable/instalado/share/apps/cmake/modules/MacroOptionalFindPackage.cmake:32 (find_package):
  By not providing "FindBoostPython.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "BoostPython", but CMake did not find one.

  Could not find a package configuration file provided by "BoostPython" with
  any of the following names:

    BoostPythonConfig.cmake
    boostpython-config.cmake

  Add the installation prefix of "BoostPython" to CMAKE_PREFIX_PATH or set
  "BoostPython_DIR" to a directory containing one of the above files.  If
  "BoostPython" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  KigConfigureChecks.cmake:12 (macro_optional_find_package)
  CMakeLists.txt:32 (include)

You probably need to somehow update KigConfigureChecks.cmake too?

- Albert Astals Cid


On Feb. 6, 2013, 2:29 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108806/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 2:29 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> With boost-1.50.0 and cmake-2.8.9 kig fails to build with following error message:
> CMakeFiles/kigpart.dir/scripting/python_scripter.o:python_scripter.cc:function initkig: error: undefined reference to 'boost::python::detail::init_module(char const*, void (*)())'
> collect2: error: ld returned 1 exit status
> make[2]: *** [lib/kigpart.so] Error 1
> 
> The attached diff fixes it for me.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aa4cc117f90ebe083d3fc5ff775e8b5e29b580db 
>   cmake/COPYING-CMAKE-SCRIPTS 4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5 
>   cmake/FindBoostPython.cmake 6d5f05edd58f0306dfa5a7ec08c1f7646427446e 
>   cmake/modules/FindBoostPython.cmake 72aae5473c61f8ae68fe5d0f104d274a182072aa 
> 
> Diff: http://git.reviewboard.kde.org/r/108806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130208/9f6c8cdb/attachment-0001.html>