Review Request 108799: Better API docs and some fixes for Analitza library

[Aleix Pol Gonzalez]

> On Feb. 6, 2013, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Wow, interesting patch Percy :)
> > 
> > I'd drop the author commands, it doesn't help much and adds clutter.
> > 
> > Also can you check if it's possible to include the code snippets from a file? this way we'll be able to have them compiling, I'd hate to forget them there...
> > 
> > Anyway, just go on and Ship It! (tm), we'll see how to polish it in the future. \o/
> >

Percy, I just reverted the commit, since it broke the build and the logic. Two things: please don't mix documentation commits and code commits and when there's a commit with code changes, please compile and run the tests.

Thanks


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108799/#review26741
-----------------------------------------------------------


On Feb. 6, 2013, 8:17 a.m., Percy Camilo Triveño Aucahuasi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108799/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 8:17 a.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> In this patch:
> 
> * Improved documentation of Analitza library: tutorials, demos and API reference.
> * Some fixes for PlotBuilder and PlotsFactory, note the the need of know about a Variables module have to be inside PlotsFactory an not PlotBuilder, rationale: Some expressions can contains variables of any arbitrary Variables module (See the tutorial 3 in the apidocs) 
> 
> Best regards,
> Percy
> 
> 
> Diffs
> -----
> 
>   Mainpage.dox 0322cd8f0feec89a4c3c35bdb209bcc07f65bdb0 
>   analitza/analitzautils.h b7edb5ba0a710c665d2260709c2f41f374fc3751 
>   analitza/analyzer.h f3b3cabc6ecbfcdd8c59b06718e33f6771f81ac1 
>   analitza/apply.h 21032f4aeb4682825afbe19183dc1a78daf3a5e7 
>   analitza/container.h 8d81ab2bc0661eb5e91bb718da6d02f303272565 
>   analitza/customobject.h afa50b6015dc16e19574dc72766c7a2413fd7b76 
>   analitza/expression.h b1f8f3edcef4febfdccbd9281953972cd923c1af 
>   analitza/expressionwriter.h c114df5fbfbc479f30937b1d13dd990bba64eaf9 
>   analitza/htmlexpressionwriter.h ba84cab40a8ed05610a1d50344be04a648689f58 
>   analitza/importqobjectmetatype.h 25a99aeda448efd562767fae0e64c8b8570823b3 
>   analitza/list.h 7afb72cb0fa2b9e5e9efd383749f1d3d270198b8 
>   analitza/operator.h dd7a93ed7eb6439cbd39dd28b3302483671854fd 
>   analitza/polynomial.h ae62055815c030ae2df582296efa614a074c3f06 
>   analitza/providederivative.h 618a35fe74a02f8313e52a6dacc08f8a8d5e94ed 
>   analitza/stringexpressionwriter.h 3d1934919439a4fdc72f7be03549f6d07ab647fb 
>   analitza/value.h 118578ccd77ef42e35356bd2edf31bef883474e7 
>   analitza/variable.h f8349c411c131ded4154314cb59fc928c63509ec 
>   analitza/variables.h bf6dd89a789a5bc7819defbd5f1d58566c97649a 
>   analitza/vector.h 035fede8ca1864b262b55fb780c9568ad832d884 
>   analitzagui/algebrahighlighter.h fd513c88b0b5b3d164db7ad01e275bcc421dbdd6 
>   analitzagui/algebrahighlighter.cpp da0e09b0dda2831048b7be846aba367d01e2d037 
>   analitzagui/expressionedit.h 031f1a76c559b39a0c469ed5a31d67e31cc4afa2 
>   analitzagui/operatorsmodel.h 16cf3f9313aa7b47e32af1883f056100fbc065aa 
>   analitzagui/operatorsmodel.cpp fae2f67209cc3b6ed39b097029fb3e822e6c44b0 
>   analitzagui/plotsview2d.h af83d0657c6f2403e4a455af54d649dd8be3e200 
>   analitzagui/plotsview3d.h 2c12eacff547cc26d52bf92e3efdc7dbe2060d4f 
>   analitzagui/variablesmodel.h d32f90cdf68f389f2ffe8d6a1e4ab54feda7d3e8 
>   analitzaplot/functiongraph.h e86d01c74aa6386cee9c4bc4acdb4b98e0102fa1 
>   analitzaplot/planecurve.h bb8c89786d924a67affbeecd16615ff290761e42 
>   analitzaplot/plotitem.h 5edca2227adf10ce8fe14593c554ae17fe61080e 
>   analitzaplot/plotsfactory.h 3e0d998e1cdd7e18209ae92a07d73894f97406ff 
>   analitzaplot/plotsfactory.cpp 68851b829ea86884842932a6cd4e38cb1fe75b24 
>   analitzaplot/plotsmodel.h b2357b93e7ccb825ac472e102f930259adc9d7b2 
>   analitzaplot/plotsmodel.cpp 057c50c1e9ac5ec25e1c0c655aa9102868e7a5e9 
>   analitzaplot/plotter2d.h 2f67def8d07f31c1a50a3fca697cdad8bb6e543f 
>   analitzaplot/plotter3d.h 995b67e5e0809edc245e8d316fb879327a9542ae 
>   analitzaplot/spacecurve.h 830114541cf306eb4956914ca1f460f952b85c95 
>   analitzaplot/surface.h f96fff43ae9badb1e820458daf6d33d5484828f4 
> 
> Diff: http://git.reviewboard.kde.org/r/108799/diff/
> 
> 
> Testing
> -------
> 
> It builds and also it produces the right html output by doxygen under the parameters of Mainpage.dox.
> 
> 
> Thanks,
> 
> Percy Camilo Triveño Aucahuasi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130207/ee0a36cb/attachment.html>