Review Request 108048: Google Code-In Task: Fix Marble Code Checker Issues

[Kevin Krammer]

> On Feb. 6, 2013, 11:17 p.m., Albert Astals Cid wrote:
> > Has this been committed? It has Ship It! but still shows open in reviewboard.

I think it has been committed, see comment by "Commit Hook" further above


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108048/#review26807
-----------------------------------------------------------


On Dec. 31, 2012, 3:13 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108048/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 3:13 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Check for normalized SIGNAL and SLOT signatures [normalize]
> 
> 
> Diffs
> -----
> 
>   src/plugins/network/kio/KIONetworkPlugin.cpp 3adcaca 
>   src/plugins/network/qhttp/QHttpNetworkPlugin.cpp fa2dca8 
>   src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.cpp f09e0b1 
>   src/plugins/positionprovider/gpsd/GpsdConnection.cpp 24fc783 
>   src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 39ff9b2 
>   src/plugins/positionprovider/gpsd/GpsdThread.cpp 6cc015f 
>   src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp 00d3e92 
>   src/plugins/positionprovider/placemark/PlacemarkPositionProviderPlugin.cpp 163f1bf 
>   src/plugins/positionprovider/qtmobility/QtMobilityPositionProviderPlugin.cpp fe51411 
>   src/plugins/positionprovider/routesimulation/RouteSimulationPositionProviderPlugin.cpp 29bbb15 
>   src/plugins/positionprovider/wlocate/WlocatePositionProviderPlugin.cpp 469eafb 
>   src/plugins/render/navigation/NavigationFloatItem.cpp a8b5ca9 
> 
> Diff: http://git.reviewboard.kde.org/r/108048/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130207/1064d929/attachment.html>