Review Request 108592: Added some more operations in analitza

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108592/#review26541
-----------------------------------------------------------


Where did you get the lg command from? For the moment we're only implementing the operators suggested by MathML content markup [1]

Also you didn't clean up the imaginary numbers changes, please review it and make sure you know what you're trying to get in.

[1] http://www.w3.org/TR/MathML2/chapter4.html#contm.funopqual

- Aleix Pol Gonzalez


On Feb. 2, 2013, 2:31 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108592/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 2:31 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> I added a few logic gates operations like xnor,nor ,log function lg(base 2),and complex functions -real,imaginary,conjugate,argument.
> 
> 
> Diffs
> -----
> 
>   analitza/operations.cpp 37b9820 
>   analitza/operator.h dd7a93e 
>   analitza/operator.cpp 4e5535b 
>   analitza/tests/analitzatest.cpp f41aaf1 
> 
> Diff: http://git.reviewboard.kde.org/r/108592/diff/
> 
> 
> Testing
> -------
> 
> I am not sure about the complex functions rest seems fine I guess :p(Though compiled successfully)
> 
> 
> File Attachments
> ----------------
> 
> removed complex functions 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/analitza.patch
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130202/3ca51dec/attachment.html>