Review Request 114745: [Kig] File Loading Based on MIME Types

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114745/
-----------------------------------------------------------

(Updated Dec. 31, 2013, 2:48 a.m.)


Review request for KDE Edu and David Faure.


Changes
-------

Adding a snapshot of the open file dialog, it doesn't show the file extensions now.


Repository: kig


Description
-------

These are changes I worked months ago when I found and fixed bug 322578. Back then I had a brief e-mail exchange with dfaure about this change and he thought it is better to load files based on their MIME types instead of the file extensions. Besides the fact that it loads the files  based on their MIME types, these changes also modernize the loading of the Kig part by using KService, and querying the KService for the supported MIME types to load. There's a noticeable change in the UI, see the attached picture.


Diffs
-----

  filters/filter.h 970da7b 
  filters/filter.cc 8d5a676 
  kig/kig.h fe56bfd 
  kig/kig.cpp e426deb 
  kig/kig_part.desktop 9c7139e 

Diff: https://git.reviewboard.kde.org/r/114745/diff/


Testing
-------

Loaded all files in the example folder of the kig repository, all loading OK. It lists exactly 8 files, same as my 4.12 installation of Kig.


File Attachments (updated)
----------------

No file extensions shown in the Open File dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/87ba4f49-ab1e-411b-9491-422484d8f2a5__kignewfilters.png


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131231/e4c4be89/attachment-0001.html>