Review Request 114692: Better Plotter2D

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114692/#review46424
-----------------------------------------------------------

Ship it!


In general it looks good to me, once this issues have been sorted out, you can commit. (But please, sort them out)


analitzagui/plotsview2d.h
<https://git.reviewboard.kde.org/r/114692/#comment33101>

    Seems like you want these methods virtual.



analitzaplot/plotter2d.cpp
<https://git.reviewboard.kde.org/r/114692/#comment33099>

    Why did you change that?
    



analitzaplot/plotter2d.cpp
<https://git.reviewboard.kde.org/r/114692/#comment33103>

    This changes behavior. Why?



analitzaplot/plottingenums.h
<https://git.reviewboard.kde.org/r/114692/#comment33098>

    Unrelated changes, please don't commit those brace movements


- Aleix Pol Gonzalez


On Dec. 28, 2013, 8:09 a.m., Percy Camilo Triveño Aucahuasi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114692/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 8:09 a.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> - Fix many bugs (ticks, labels, zooming, etc,)
> - Add polar angles and polar axis.
> - Add option to draw the angles in radians, degrees and gradians.
> - Add new grid styles (some similar to KmPlot like crosses)
> - Better API to manage colors and to set render options (like drawticks, etc.)
> - Many minor fixes/improvements too.
> 
> 
> Diffs
> -----
> 
>   analitzaplot/plottingenums.h f0c4c1c 
>   analitzaplot/private/utils/mathutils.h 08630b8 
>   analitzaplot/private/utils/mathutils.cpp d44ed6d 
>   analitzagui/plotsview2d.h b08a716 
>   analitzagui/plotsview2d.cpp f66f22d 
>   analitzaplot/plotitem.h efe942c 
>   analitzaplot/plotter2d.h ac52684 
>   analitzaplot/plotter2d.cpp 48085f1 
>   analitzaplot/plotter3d.h 85c3378 
> 
> Diff: https://git.reviewboard.kde.org/r/114692/diff/
> 
> 
> Testing
> -------
> 
> All test pass, all analitzaplot demos run ok
> 
> 
> Thanks,
> 
> Percy Camilo Triveño Aucahuasi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131230/19f7c30d/attachment-0001.html>