Review Request 114006: Update min and max value at the same time in order to be more friendly with typing in the min/max box

Yichao Yu yyc1992 at
Sat Dec 28 17:23:22 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 28, 2013, 5:23 p.m.)


This change has been marked as submitted.

Review request for KDE Edu, Laurent Montel and Jeremy Whiting.

Repository: kalzium


This patch makes the behavior while typing in the min/max boxes more friendly.

Currently if one types in the maximum value box, the minimum value will stuck at a small value due to the small value in the maximum value box before one finish typing. (I don't really call this a bug, but I think it is not friendly.)

This patch tries to update both the maximum and minimum values whenever one of them changes (in the right order to always respect the one that changes) so that the actual range displayed is always the closed possible to the input values. It also covers the cases when min/max values change from illegal values to legal values (max > min) in some other ways.


  src/spectrumviewimpl.h c596154 
  src/spectrumviewimpl.cpp 0327202 
  src/spectrumwidget.h 5117d26 



Compiles and fixes the problem.


Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list