Review Request 112154: Make it possible to edit language settings in practice mode

Inge Wallin inge at lysator.liu.se
Mon Aug 19 13:46:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112154/#review38137
-----------------------------------------------------------



src/editor/editor.cpp
<http://git.reviewboard.kde.org/r/112154/#comment28197>

    Hmm, seems like an extra newline, yes.  I'll check it.


- Inge Wallin


On Aug. 19, 2013, 11:11 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112154/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:11 a.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Currently Parley has a setting for editing language settings such as fontsize in the editor and practice and also other, more language specific things.  But this is extremely well hidden in the editor mode only and under the Edit menu.
> 
> This patch makes the language settings available also during practice.
> 
> You could argue that settings for the language itself should be separated from viewing settings but this is not the topic of this patch.
> 
> 
> Diffs
> -----
> 
>   src/editor/editor.cpp 6511a69 
>   src/practice/practicemainwindow.cpp 9f23ae9 
>   src/practice/practiceui.rc 96c4a06 
> 
> Diff: http://git.reviewboard.kde.org/r/112154/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130819/56244b38/attachment.html>


More information about the kde-edu mailing list