Review Request 111788: Remove <!DOCTYPE> from UI messages

Commit Hook null at kde.org
Sat Aug 17 19:51:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111788/
-----------------------------------------------------------

(Updated Aug. 17, 2013, 7:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Description
-------

Simplify their HTML otherwise as well. This makes them much more pleasant to translate.

For example replace <span style="font-size:12pt"> with <big> and <span style="font-weight:600;"> with <b>.

Also in calculator.ui change one message to use the h1 tag because I couldn't find much difference in font size or weight when compared to <span style="font-size:18pt; font-weight:600;">.

Also change <span style="font-size:14pt"> to <big>. There is a size difference, but I don't know if it's big enough to warrant using a different tag. Fixed font sizes are not good.

Sorry about the unrelated formatting changes Qt Designer made to some .ui files.


Diffs
-----

  src/calculator/calculator.ui 853f5b2 
  src/calculator/concCalculator.ui b3ad5b1 
  src/calculator/gasCalculator.ui 9e862d8 
  src/calculator/nuclearCalculator.ui d973ba0 
  src/calculator/settings_calc.ui 0c1e301 
  src/isotopetable/isotopedialog.ui 2fb02e6 

Diff: http://git.reviewboard.kde.org/r/111788/diff/


Testing
-------

Checked that they looked good in Qt Designer. For some also checked how they looked when running Kalzium.


File Attachments
----------------

Calculator window before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_before.png
Calculator window after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_after.png
Isotope table before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_before.png
Isotope table after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_after.png


Thanks,

Lasse Liehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130817/62c7a981/attachment.html>


More information about the kde-edu mailing list