Review Request 111470: Allow loading google images plugin on non-ASCII locales

Commit Hook null at kde.org
Thu Aug 15 04:39:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111470/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 4:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Frederik Gladhorn.


Description
-------

Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message:

/usr/share/apps/parley/plugins/google_images.py, line 250:
'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
action1.statusTip = str(i18n("Fetches an image for the selected translation"))

This patch tries to avoid this inconvenience.


Diffs
-----

  plugins/google_images.py 5317ba6 

Diff: http://git.reviewboard.kde.org/r/111470/diff/


Testing
-------

No errors while loading editor. Plugin does not work anyway, but it's a different story. ;)


Thanks,

Yuri Chornoivan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130815/8461e488/attachment.html>


More information about the kde-edu mailing list