Review Request 110086: Solved the problem with the filter support using drop-down menu in Khipu
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Apr 24 11:50:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110086/#review31488
-----------------------------------------------------------
src/dashboard.cpp
<http://git.reviewboard.kde.org/r/110086/#comment23457>
Here you're not setting the parent widget, so please merge the 2 constructors.
- Aleix Pol Gonzalez
On April 19, 2013, 1:34 p.m., Punit Mehta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110086/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 1:34 p.m.)
>
>
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
>
>
> Description
> -------
>
> Solved the issue of filter by dimension.. Now, plots can be easily differenciated by using DimALL,Dim2D,Dim3D in the drop-down menu. I am working for the text edit part , now...!
>
>
> Diffs
> -----
>
> src/dashboard.h a2a9c46
> src/dashboard.cpp 688a49d
> src/filter.h 80085f3
> src/filter.cpp 16b6b8e
> src/mainwindow.cpp 9d6e010
>
> Diff: http://git.reviewboard.kde.org/r/110086/diff/
>
>
> Testing
> -------
>
> Done..! Worked perfectly for the drop-down box.!
>
>
> Thanks,
>
> Punit Mehta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130424/92015159/attachment.html>
More information about the kde-edu
mailing list