Review Request 107106: Adds support for Share-Like-Connect, making ktouch activity enabled.

[Sebastian Gottfried]

> On April 4, 2013, 6:16 p.m., Albert Astals Cid wrote:
> > If noone reviews this I'll discard it in one month, seems noone is really interested in the feature.

This request can be discarded right now IMO. The proposed patch was developed against the old 1.x series of KTouch and doesn't apply against the current version both literally and conceptionally. From my understanding Activity support makes only sense for applications where the user is working on/with some kind of document. This isn't the case for KTouch.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107106/#review30388
-----------------------------------------------------------


On Oct. 29, 2012, 11:27 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107106/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 11:27 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This small patch adds support for Share Like Connect and the activity infrastructure done by Ivan.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d29339b 
>   src/CMakeLists.txt bcfa5cb 
>   src/ktouch.h 9c2dede 
>   src/ktouch.cpp dfba976 
> 
> Diff: http://git.reviewboard.kde.org/r/107106/diff/
> 
> 
> Testing
> -------
> 
> Compiled, not crashing.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130405/b56f02b1/attachment.html>