Review Request 109804: [Kig] Add Projection Construction

[Maurizio Paolini]

I can take care of it...  There is one thing that must be changed:

+static const ArgsParser::spec argsspecProjectedPoint[] =
+{
+  { PointImp::stype(), "Point to project",
+    I18N_NOOP( "Select a point to project onto a line..." ), false },
+  { LineImp::stype(), "Line where to project",
+    I18N_NOOP( "Line where the projected point will lie..." ), false }
+};

should instead be:

+static const ArgsParser::spec argsspecProjectedPoint[] =
+{
+  { PointImp::stype(), "Point to project",
+    I18N_NOOP( "Select a point to project onto a line..." ), false },
+  { LineImp::stype(), "Line where to project",
+    I18N_NOOP( "Line where the projected point will lie..." ), true }
+};

explanation: "true" corresponds to a notion of "incidence by construction";
in this case because the constructed point id "by construction" on the
line.  An example of construction that makes the problem clear:

1. construct a point P and line l by two points
2. project P onto l (with the new construction)
3. construct a conic by P and other (new) 4 points
4. intersect the conic with the line

---

a new point will be constructed coincident with P (because kig is not aware
that such intersection was already there).
With "true" in place of "false" kig will know that P is one of the two 
intersections and will only construct the other one.

Maurizio



On Tue, Apr 02, 2013 at 10:09:27PM -0000, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109804/#review30297
> -----------------------------------------------------------
> 
> 
> Is anyone planning on reviewing this?
> Maurizio? Pino?
> 
> - Albert Astals Cid
> 
> 
> On March 30, 2013, 7:45 p.m., David Narváez wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/109804/
> > -----------------------------------------------------------
> > 
> > (Updated March 30, 2013, 7:45 p.m.)
> > 
> > 
> > Review request for KDE Edu.
> > 
> > 
> > Description
> > -------
> > 
> > The foot of the perpendicular from a point to a line
> > 
> > 
> > Diffs
> > -----
> > 
> >   icons/hi22-action-projection.png PRE-CREATION 
> >   icons/hi32-action-projection.png PRE-CREATION 
> >   icons/hisc-action-projection.svgz PRE-CREATION 
> >   kig/kigpartui.rc 6cc09d30143d13095b0f900346ef0786f03669aa 
> >   misc/builtin_stuff.cc fdb6a870b5ce46539899b7220dd855bee9d2e747 
> >   objects/point_type.h 25cadf2acfdbf6b161ee5cdc2f20b124f60876a6 
> >   objects/point_type.cc deb6ea48b5212144c71b0c10b29f2f17adde3180 
> > 
> > Diff: http://git.reviewboard.kde.org/r/109804/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > 1. Construct a projection using the Object menu
> > 2. Construct a projection using the right-click popup menu
> > 
> > 
> > Thanks,
> > 
> > David Narváez
> > 
> >
> 

> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu