Review Request: Implement an explicit default constructor for the variables model

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Sep 24 14:11:47 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106556/#review19386
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Sept. 24, 2012, 2 p.m., Laszlo Papp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106556/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 2 p.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> There is the understanding with the change that the "m_vars" member variable is not filled in at registration time, so this should be done elsewhere either by a mutator method or a default value. Perhaps this should be something else.
> 
> Either way, this is now making the building working which is needed for the kdeedu package generation. Let me know if I can help with a better approach. We would not probably use this frontend on Windows 7, but one could say as the state of art, this could be run on Windows tablet for now. Thereby, the KDE Windows team would like to get it solved instead of explicitely disabling. It is also a valid use case for the clients to have a registerable model on Windows as well.
> 
> 
> Diffs
> -----
> 
>   analitzagui/variablesmodel.h c5551de 
>   analitzagui/variablesmodel.cpp 681beb9 
> 
> Diff: http://git.reviewboard.kde.org/r/106556/diff/
> 
> 
> Testing
> -------
> 
> Build and runtime test. Do not see outstanding issues cased by this so far, but it was a brief runtime test admittedly. :-)
> 
> 
> Thanks,
> 
> Laszlo Papp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120924/646ed61c/attachment.html>


More information about the kde-edu mailing list