Review Request: Make libkdeedu tests pass

Frederik Gladhorn gladhorn at kde.org
Mon Sep 17 12:28:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106454/#review19062
-----------------------------------------------------------

Ship it!


Ship It!

- Frederik Gladhorn


On Sept. 16, 2012, 2:37 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106454/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2012, 2:37 p.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Make the tests pass, code looks more logical now
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvoctext.cpp 4df6bd7 
>   keduvocdocument/keduvocwordtype.cpp 87aeebb 
> 
> Diff: http://git.reviewboard.kde.org/r/106454/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests, Parley is the only app using those functions as far as i can see, not sure how to trigger those from Parley, hence including fregl on the review request
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120917/659a5254/attachment.html>


More information about the kde-edu mailing list