Review Request: Adds support for Share-Like-Connect, making khangman activity enabled

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107109/#review21104
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/107109/#comment16550>

    You need to specify the version 6.1.0
    
    Is the khangman author willing to make this a hard-dependency



src/desktop/khangman.cpp
<http://git.reviewboard.kde.org/r/107109/#comment16551>

    If it is not in #ifdef, no point in having the comma in this line



src/desktop/khangman.cpp
<http://git.reviewboard.kde.org/r/107109/#comment16552>

    No need for this - it has a parent set in 563


- Ivan Čukić


On Oct. 29, 2012, 11:31 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107109/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 11:31 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This small patch adds support for Share Like Connect and the activity infrastructure done by Ivan.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f90ba30 
>   src/desktop/CMakeLists.txt 65f0295 
>   src/desktop/khangman.h ad28633 
>   src/desktop/khangman.cpp 5b5b774 
> 
> Diff: http://git.reviewboard.kde.org/r/107109/diff/
> 
> 
> Testing
> -------
> 
> Compiled, not crashing.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121029/128e7589/attachment.html>