Review Request: Adds support for Share-Like-Connect, making kalgebra activity enabled.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107110/#review21083
-----------------------------------------------------------

Ship it!


It's fine, although I don't really like the conditional compilation. Can't we just have KDE Edu depend on the library?
The runtime dependency I understand that it can be harder, but I don't think we should have a KDE Edu version that doesn't support Activities and one that does...

- Aleix Pol Gonzalez


On Oct. 29, 2012, 11:33 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107110/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 11:33 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This small patch adds support for Share Like Connect and the activity infrastructure done by Ivan.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e7d5478 
>   src/CMakeLists.txt ed767f3 
>   src/kalgebra.h 3a4b378 
>   src/kalgebra.cpp a96d1fc 
> 
> Diff: http://git.reviewboard.kde.org/r/107110/diff/
> 
> 
> Testing
> -------
> 
> Compiled, not crashing.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121029/c3b57a8e/attachment.html>