Review Request: Set Antialiasing in Kig

[Albert Astals Cid]

> On April 15, 2012, 10:26 p.m., Albert Astals Cid wrote:
> > To be honest i'm not sure i like the antialiased variants more, but on the other hand, i'm not a user of kig so not sure you should be listening to me :D
> 
> David Narváez wrote:
>     I actually have no preference over one or the other. Maybe add a configuration checkbox to use antialiasing?
> 
> Albert Astals Cid wrote:
>     Ping? I don't think a configuration is the best of the ideas, maybe a hidden one? E.g. something that is documented in the manual but not exposed in the gui? Noone else has an opinion?
> 
> David Narváez wrote:
>     I thought I'd put this into a new config screen for Kig which currently only lives in my head, so I haven't pushed for this review request any more. Still, if anybody has arguments for or against antialiasing, we're still listening.

David I'm discarding this review so we get a cleaner list/queue of things that are yet to review, this doesn't mean this is a yes/no for the feature, but as you are still working on it i think it's better to have a cleaner reviewboard list and once you are finished you open a new one or reopen this one.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104584/#review12491
-----------------------------------------------------------


On April 15, 2012, 5:26 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104584/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 5:26 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Pretty straightforward, the question is actually if anybody disagrees. The one issue I would be concerned about is performance, but I would expect this not to be an issue in modern computers, yet I don't have any stress case to test this against.
> 
> 
> This addresses bug 122376.
>     http://bugs.kde.org/show_bug.cgi?id=122376
> 
> 
> Diffs
> -----
> 
>   misc/kigpainter.cpp 18d4396 
> 
> Diff: http://git.reviewboard.kde.org/r/104584/diff/
> 
> 
> Testing
> -------
> 
> Compare drawing a large circle with and without this patch to see antialiasing in action.
> 
> 
> Screenshots
> -----------
> 
> Antialiased
>   http://git.reviewboard.kde.org/r/104584/s/535/
> Aliased
>   http://git.reviewboard.kde.org/r/104584/s/536/
> Antialiased Heptagonal Tessellation
>   http://git.reviewboard.kde.org/r/104584/s/539/
> Aliased Heptagonal Tessellation
>   http://git.reviewboard.kde.org/r/104584/s/540/
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121010/d054ea78/attachment.html>