Review Request: Hint at the right resolution

[Jaime Torres Amate]

> On Oct. 8, 2012, 6:04 p.m., Albert Astals Cid wrote:
> > src/desktop/khangmanview.cpp, line 293
> > <http://git.reviewboard.kde.org/r/106659/diff/2/?file=88772#file88772line293>
> >
> >     Hmmm, shouldn't this be a fixed number? As far as I understand the point size already "scales" the font properly with the dpi, so we don't need a bigger point size for a bigger height, no?

Yes, the point size scales the font with the dpi (dots per inch). If I use another screen size/resolution, the fonts look as desired.
But when the window is resized, khangman also resizes the font to make it bigger or smaller to fit in the window, just like the svgs.

(I've tested without the division, the font size is so big that only renders one letter in the window).


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106659/#review20091
-----------------------------------------------------------


On Oct. 8, 2012, 7:43 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106659/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 7:43 a.m.)
> 
> 
> Review request for KDE Edu and Anne-Marie Mahfouf.
> 
> 
> Description
> -------
> 
> Fix for the JJ: https://bugs.kde.org/show_bug.cgi?id=258155
> From Andreas <kainz.a at gmail.com>, that is still fighting with git (and has asked me to push it for him)
> 
> 
> This addresses bug 28155.
>     http://bugs.kde.org/show_bug.cgi?id=28155
> 
> 
> Diffs
> -----
> 
>   src/desktop/khangmanview.cpp b6b748a 
>   TODO 26ad5f1 
> 
> Diff: http://git.reviewboard.kde.org/r/106659/diff/
> 
> 
> Testing
> -------
> 
> I can read the hints now at full screen.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121008/ad1f0cc3/attachment.html>