Review Request: Drop unneeded linking target
Ben Cooksley
bcooksley at kde.org
Tue Oct 2 21:15:51 UTC 2012
> On Oct. 2, 2012, 8:49 p.m., Aleix Pol Gonzalez wrote:
> > Great, thanks for looking into this!
> >
> > Maybe I could get notifications on problems in build.kde.org? or is there an RSS?
>
> Albert Astals Cid wrote:
> /me shows http://build.kde.org/job/kalgebra_master/ to Aleix
>
> Ben Cooksley wrote:
> I'll add that RSS feeds for both kdeedu as a group, and all projects on build.kde.org are also available.
> See http://build.kde.org/view/kdeedu/ and http://build.kde.org/ for more on those.
>
> In terms of email based notifications, that is a project-wide option - so making it available is being delayed for now until the precise details are sorted out.
When I tried to push this, it seems it had already been submitted in 336f5004b611b4bef8b039f3b9876165e53908a7.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106696/#review19787
-----------------------------------------------------------
On Oct. 2, 2012, 7:58 p.m., Ben Cooksley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106696/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2012, 7:58 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> KAlgebra does not seem to need QGLViewer in order to successfully compile - so remove it from the link targets to make it easier to build.
>
> It seems changes somewhere (likely in latest CMake) cause the QGLVIEWER_LIBRARY variable to be set to QGLVIEWER_LIBRARY-NOTFOUND now - instead of simply blank as it previously was when nothing was found.
>
> Removing the ${QGLVIEWER_LIBRARY} fixes the build on build.kde.org.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 7cbba68
>
> Diff: http://git.reviewboard.kde.org/r/106696/diff/
>
>
> Testing
> -------
>
> Compiles without QGLViewer available.
>
>
> Thanks,
>
> Ben Cooksley
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121002/62a162e7/attachment-0001.html>
More information about the kde-edu
mailing list