Review Request: Fix Kalzium build with -DWITH_OpenBabel2=OFF

Commit Hook null at kde.org
Wed Nov 7 06:45:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107214/#review21523
-----------------------------------------------------------


This review has been submitted with commit ed08a7eb1914a8e3a51f1dbf84a524d33cd4a119 by Michael Palimaka to branch master.

- Commit Hook


On Nov. 5, 2012, 3:13 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107214/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 3:13 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Build with -DWITH_OpenBabel2=OFF fails:
> 
> CMake Error at KalziumConfigureChecks.cmake:9 (pkg_check_modules):
>   Unknown CMake command "pkg_check_modules".
> Call Stack (most recent call first):
>   CMakeLists.txt:31 (include)
> 
> Since pkg_check_modules is now used in the root cmake file, find_package should be called there too.
> 
> 
> Diffs
> -----
> 
>   KalziumConfigureChecks.cmake fe52526ed3664e24888e38d2dc6c52d90ca2be0c 
> 
> Diff: http://git.reviewboard.kde.org/r/107214/diff/
> 
> 
> Testing
> -------
> 
> Build is successful.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121107/27c995a2/attachment.html>


More information about the kde-edu mailing list