Pairs Theme Editor
Marco Calignano
marco.calignano at gmail.com
Sat Nov 3 23:02:11 UTC 2012
Hi Albert,
I'd like to work on it, after you push the diff from the review request
you sent last week.
Thanks
Marco
On 11/02/2012 07:52 PM, Albert Astals Cid wrote:
> El Dilluns, 29 d'octubre de 2012, a les 21:50:02, Marco Calignano va escriure:
>> I get my icon from your theme. Could be that they are not implemented
>> in the theme you used?
> fixed it, braindeadness in Qt
>
>> Albert, the last commits are now in master are you still using the
>> branch pteditMerge?
> No, i'm using master
>
>> If yes, try to pull the master, build and the executable now is pairseditor
> Ok, some more issues:
> * There is no File->quit
> * The list views of elements has a header named "1"
> * The combobox that is beisdes the +/- buttons is very narrow and i only see
> the icons (and partially) it'd be much better if i could see the text (not
> sure it is) like in the "Main Type:" combo
> * If i select the first item in the list and press the "-" button, pressing it
> again does nothing, i'd expect to remove the "next" element
>
> Cheers,
> Albert
>
>> Cheers
>> Marco
>>
>> On Mon, Oct 29, 2012 at 7:08 PM, Albert Astals Cid <aacid at kde.org> wrote:
>>> El Diumenge, 28 d'octubre de 2012, a les 20:09:57, Marco Calignano va
>>>
>>> escriure:
>>>> Hi Albert,
>>>>
>>>> if your code in MainWindowView::deleteElement() looks like this:
>>>>
>>>>
>>>> void MainWindowView::deleteElement()
>>>> {
>>>>
>>>> if(!m_model || m_model->rowCount() == 0 || !m_selectedItem)
>>>>
>>>> return;
>>>>
>>>> m_model->removeItem(m_selectedItem);
>>>> m_selectedItem = 0;
>>>> emit changed();
>>>>
>>>> }
>>>>
>>>>
>>>> then tell me exactly how to reproduce the problem because I cannot do it
>>>> here If it looks different then pull again and try again please.
>>> I tould you in my first email, clicking one of the "buttons without icon"
>>> (I still have no icons, any idea why that might happen?)
>>>
>>> Cheers,
>>>
>>> Albert
>>>> Thanks for the help
>>>>
>>>> Marco
>>>>
>>>> On Sun, Oct 28, 2012 at 5:48 PM, Albert Astals Cid <aacid at kde.org> wrote:
>>>>> El Dimarts, 23 d'octubre de 2012, a les 00:33:15, Marco Calignano va
>>> escriure:
>>>>>> Hi Albert,
>>>>>>
>>>>>> On 10/22/2012 11:43 PM, Albert Astals Cid wrote:
>>>>>>> El Dimarts, 16 d'octubre de 2012, a les 23:23:44, Marco Calignano va
>>> escriure:
>>>>>>>> Hello everyone,
>>>>>>>>
>>>>>>>> like you already have seen at
>>>>>>>> http://techbase.kde.org/Schedules/KDE4/4.10_Feature_Plan#kdeedu I
>>>>>>>> am
>>>>>>>> working (together with Aleix and Heena) at the Pairs Theme Editor.
>>>>>>>> I would like it to be part of KDE 4.10 and I think that we can
>>>>>>>> make
>>>>>>>> it.
>>>>>>>> Of course my judgment is a bit bias, so I ask you to try it out and
>>>>>>>> tell
>>>>>>>> me what you think about it.
>>>>>>>> I know it is not completely bug free but you can get an Idea if it
>>>>>>>> can
>>>>>>>> be released in January or not.
>>>>>>>> You find it in the pairs repository in the pteditMerge branch.
>>>>>>>> Any feedback is appreciated.
>>>>>>> Problem 1:
>>>>>>> You don't have a .desktop file, thus your app doesn't show up in the
>>>>>>> menus, thus your app is basically impossible to find unless you know
>>>>>>> it
>>>>>>> exists
>>>>>> I need still to do the .desktop file, true;
>>>>>>
>>>>>>> Problem 2:
>>>>>>> Installed it, had a window on which there was lots of stuff,
>>>>>>> including
>>>>>>> two
>>>>>>> buttons with no text nor images, that made me curious so i clicked
>>>>>>> them
>>>>>>> and the editor crashed.
>>>>>> Try to pull the version of this evening I fixed the bug you are
>>>>>> having.
>>>>> Still crashes
>>>>>
>>>>>
>>>>> ==7767== Conditional jump or move depends on uninitialised value(s)
>>>>> ==7767== at 0x411A99: MainWindowView::deleteElement()
>>>>> (mainwindowview.cpp:221) ==7767== by 0x40BB1F:
>>>>> MainWindowView::qt_static_metacall(QObject*, QMetaObject::Call, int,
>>>>> void**) (moc_mainwindowview.cpp:71) ==7767== by 0x6E51F5E:
>>>>> QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.3) ==7767== by 0x6305421:
>>>>> QAbstractButton::clicked(bool) (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767== by 0x6058D2D:
>>>>> QAbstractButtonPrivate::emitClicked() (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767== by 0x605955F:
>>>>> QAbstractButtonPrivate::click() (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767== by 0x60597CB:
>>>>> QAbstractButton::mouseReleaseEvent(QMouseEvent*) (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767== by 0x5CEA84F:
>>>>> QWidget::event(QEvent*) (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3)
>>>>> ==7767== by 0x5C9AE9B: QApplicationPrivate::notify_helper(QObject*,
>>>>> QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767==
>>>>> by
>>>>> 0x5C9FB6A: QApplication::notify(QObject*, QEvent*) (in
>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==7767== by 0x50AF519:
>>>>> KApplication::notify(QObject*, QEvent*) (kapplication.cpp:311) ==7767==
>>>>>
>>>>> by 0x6E3C56D: QCoreApplication::notifyInternal(QObject*, QEvent*) (in
>>>>>
>>>>> /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.3)
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Albert
>>>>>> Cheers
>>>>>> Marco
>>>>>>
>>>>>>> Valgrind says:
>>>>>>> ==9631== Conditional jump or move depends on uninitialised value(s)
>>>>>>> ==9631== at 0x4112D1: MainWindowView::deleteElement()
>>>>>>> (mainwindowview.cpp:209) ==9631== by 0x40B8E0:
>>>>>>> MainWindowView::qt_static_metacall(QObject*, QMetaObject::Call, int,
>>>>>>> void**) (moc_mainwindowview.cpp:66) ==9631== by 0x6E51F5E:
>>>>>>> QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.3) ==9631== by
>>>>>>> 0x6305421:
>>>>>>> QAbstractButton::clicked(bool) (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631== by
>>>>>>> 0x6058D2D:
>>>>>>> QAbstractButtonPrivate::emitClicked() (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631== by
>>>>>>> 0x605955F:
>>>>>>> QAbstractButtonPrivate::click() (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631== by
>>>>>>> 0x60597CB:
>>>>>>> QAbstractButton::mouseReleaseEvent(QMouseEvent*) (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631== by
>>>>>>> 0x5CEA84F:
>>>>>>> QWidget::event(QEvent*) (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3)
>>>>>>> ==9631== by 0x5C9AE9B:
>>>>>>> QApplicationPrivate::notify_helper(QObject*,
>>>>>>> QEvent*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631==
>>>>>>> by
>>>>>>> 0x5C9FB6A: QApplication::notify(QObject*, QEvent*) (in
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.3) ==9631== by
>>>>>>> 0x50AF519:
>>>>>>> KApplication::notify(QObject*, QEvent*) (kapplication.cpp:311)
>>>>>>> ==9631==
>>>>>>>
>>>>>>> by 0x6E3C56D: QCoreApplication::notifyInternal(QObject*, QEvent*)
>>>>>>> (in
>>>>>>>
>>>>>>> /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.3)
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Albert
>>>>>>>> Cheers
>>>>>>>> Marco
>>>>>>>> _______________________________________________
>>>>>>>> kde-edu mailing list
>>>>>>>> kde-edu at mail.kde.org
>>>>>>>> https://mail.kde.org/mailman/listinfo/kde-edu
>>>>>>> _______________________________________________
>>>>>>> kde-edu mailing list
>>>>>>> kde-edu at mail.kde.org
>>>>>>> https://mail.kde.org/mailman/listinfo/kde-edu
>>>>>> _______________________________________________
>>>>>> kde-edu mailing list
>>>>>> kde-edu at mail.kde.org
>>>>>> https://mail.kde.org/mailman/listinfo/kde-edu
>>>>> _______________________________________________
>>>>> kde-edu mailing list
>>>>> kde-edu at mail.kde.org
>>>>> https://mail.kde.org/mailman/listinfo/kde-edu
>>>> _______________________________________________
>>>> kde-edu mailing list
>>>> kde-edu at mail.kde.org
>>>> https://mail.kde.org/mailman/listinfo/kde-edu
>>> _______________________________________________
>>> kde-edu mailing list
>>> kde-edu at mail.kde.org
>>> https://mail.kde.org/mailman/listinfo/kde-edu
>> _______________________________________________
>> kde-edu mailing list
>> kde-edu at mail.kde.org
>> https://mail.kde.org/mailman/listinfo/kde-edu
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
>
More information about the kde-edu
mailing list