Review Request: Refactor and improve the PGF/TikZ exporter of Kig.

David Narváez david.narvaez at computer.org
Mon Mar 19 05:32:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104270/#review11605
-----------------------------------------------------------

Ship it!


I think that, after removing whitespaces (they are marked in red in the patch) this is good to go. I think this goes to master only, as it breaks binary compatibility, right?

- David Narváez


On March 14, 2012, 5:17 p.m., raoul bourquin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104270/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 5:17 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Description
> -------
> 
> Refactor and improve the PGF/TikZ exporter of Kig.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e8b48b2 
>   filters/latexexporter.cc bad5b85 
>   filters/pgfexporterimpvisitor.h PRE-CREATION 
>   filters/pgfexporterimpvisitor.cc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> raoul bourquin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120319/8646b91b/attachment.html>


More information about the kde-edu mailing list