KmPlot sliders usage and associated bug
Anne-Marie Mahfouf
annemarie.mahfouf at free.fr
Sat Mar 17 12:06:21 UTC 2012
On 03/17/2012 01:00 PM, Rahul Sharma wrote:
> So, the work to do is this.
> I have to remove close button and set the visibility of Sliders check
> box and of the Show Sliders Menu only when the user
> enters the any parameter in the function.
> Should I go on doing it then?
This is my opinion, yes. If anyone objects, please speak up!
Anne-Marie
>
> On Sat, Mar 17, 2012 at 3:22 PM, Anne-Marie Mahfouf
> <annemarie.mahfouf at free.fr <mailto:annemarie.mahfouf at free.fr>> wrote:
>
> On 03/17/2012 09:47 AM, todd rme wrote:
>
> On Sun, Mar 4, 2012 at 7:59 PM, Anne-Marie Mahfouf
> <annemarie.mahfouf at free.fr <mailto:annemarie.mahfouf at free.fr>>
> wrote:
>
> On 03/04/2012 06:56 PM, todd rme wrote:
>
> On Sun, Mar 4, 2012 at 6:38 PM, Anne-Marie Mahfouf
> <annemarie.mahfouf at free.fr
> <mailto:annemarie.mahfouf at free.fr>> wrote:
>
> On 03/04/2012 09:02 AM, Rahul Sharma wrote:
>
> Hi,
> I looked into the view.cpp updatesliders()
> function, and I have arrived
> at
> the conclusion that the variable needSliderWindow
> does have a use here. I
> think that the control if() statement, in which
> the bool variable
> needSliderWindow is set to true, it checks whether
> the Slider checkbox in
> the left panel (function tab) is checked or not,
> depending on which it
> sets
> the checkable bool of m_menuSliderAction to true.
>
> And I think the intention was that when the Slider
> checkbox is checked,
> the
> slider window should pop-up and when it is
> unchecked slider window should
> hide.
>
> So the first thing would be to fix this.
> Should closing the Sliders window uncheck the
> Slider checkbox? What
> should
> happen when the Sliders window is closed?
> Also why is there the possibility to check Slider
> when there is no Slider
> use? Like in a function witn no parameter.
>
> Anne-Marie
>
>
> And as you were saying there is no need to have
> that as a toggle. That
> can
> be done in another way and just setting
> m_menuSliderAction->setchecked(true)
> does not fulfill the aim here.
>
> And one more thing I wanted to point out here is
> about my patch.
> Actually,
> when I looked into the code of the
> ksliderwindow.cpp, I found out that in
> order to handle the check of the
> m_menuSliderAction there is a slot
> called
> closeevent which emits a windowclosed signal when
> the window is closed,
> which is only called when closeevent is called.
> But the close button of
> the
> slider window uses a done() (perhaps inheritted
> from QDialog as far as I
> remember) to close the window which does not emit
> a closeevent and the
> the
> m_menuSliderAction becomes faulty, so I just fixed
> that.
>
> -Regards
> Rahul Sharma
> (NUM_1 on irc.freenode.net <http://irc.freenode.net>)
>
> Slightly off-topic, but why is this is a window and
> not a dock panel?
> Doc panels can be pulled off and used as separate
> windows, but they
> can also be integrated into the GUI.
>
> We are trying to find out the use of this Sliders dialog.
> As I said, it is
> not needed in plots without parameters so a dock for this
> would take space
> without any purpose. Dialogs do not have the same scope
> than docks and
> probably only a fraction of users make use of the sliders.
>
>
> Anne-Marie
>
> Docks are not permanent, they can be opened and closed. Look at
> dolphin, it has 5 docs, only 1 of which is enabled by default if I
> remember correctly. The other can be enabled or disabled at
> will from
> a menu or toolbar button.
>
> In this regard it would be little different from the current
> system.
> Someone clicks the menu item to open it, and it opens in a
> dock. Then
> if the person clicks the menu item again, or clicks the close
> button
> on the doc, it disappears and the other docs reshape to fill the
> space.
>
> Further, the doc could be pulled off to act as a standalone
> window if
> you want, meaning users can have it behave identically to how it
> currently behaves. So we lose nothing, but we gain
> improvements in
> window management.
>
> -Todd
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org <mailto:kde-edu at mail.kde.org>
> https://mail.kde.org/mailman/listinfo/kde-edu
>
>
> Sliders are only relevant with functions with parameters.
> 1) Even without a parameter you can currently check Sliders which
> makes no sense: in my opinion when there is no parameter (for
> example f(x)=sin(x)), the Slider checkbox in the function tab
> should be disabled (grayed) and so should be the View -> Show
> Sliders option.
> 2) When there is a parameter (for example f(x,a)= sin(x+a)),
> without any slider the parameter value is set to 0. You now need
> to set the parameter value with the sliders (you can set 4 values)
> and you can also move a slider to show the students the parameter
> variation on the plot.
> So you need the Slider checkbox and the View-> Show Sliders enabled.
> View -> Show Sliders shows the Sliders dialog which allows to set
> the sliders values. If you uncheck this through View->Show
> Sliders, the dialog hides. The bug is the Close button which does
> not uncheck View->Show Sliders (addressed by patch). Shouldn't the
> Close button be removed in this dialog?
>
> I don't see on my laptop how to fit another dock instead of this
> dialog, Todd. And there's no need to have this dock when you deal
> with no parameters (people would add this dock and leave it probably).
>
> Personally I would disable the Sliders when there's no parameters
> and remove the Close button in the dialog, leaving the View ->
> Show Sliders as it is.
>
> Anne-Marie
>
>
>
>
>
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org <mailto:kde-edu at mail.kde.org>
> https://mail.kde.org/mailman/listinfo/kde-edu
>
>
>
> _______________________________________________
> kde-edu mailing list
> kde-edu at mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120317/872275ef/attachment-0001.html>
More information about the kde-edu
mailing list