Review Request: Fix potential Cantor parallel build issue

Michael Palimaka kensington at gentoo.org
Tue Jul 31 12:53:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105804/
-----------------------------------------------------------

Review request for KDE Edu.


Description
-------

It was reported downstream that it may be possible for Cantor to fail a parallel build:

src/backends/qalculate/plotassistant/qalculateplotassistant.h:37:11: error: 'QalculateSettings' was not declared in this scope

Investigation points towards an error in the build dependency tree. cantor_qalculateplotassistant depends on ../settings.kcfgc which produces ./settings.h, but ../settings.h from some other target is referenced (in qalculateplotassistant.h).

This patch just changes this to use the settings.h generated by the correct target.


Diffs
-----

  src/backends/qalculate/plotassistant/qalculateplotassistant.h ac55b51cd67c1c403f28ca99eb72390a2f03a834 

Diff: http://git.reviewboard.kde.org/r/105804/diff/


Testing
-------

The contents of both settings.h files are the same.
Build is normal, and settings.h is now correctly regenerated when expectantly missing.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120731/46b3dd91/attachment.html>


More information about the kde-edu mailing list