Review Request: Set Antialiasing in Kig

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104584/#review16144
-----------------------------------------------------------


If you enable antialiasing, you should account for the 0.5 pixel offset, so that straight lines do not get two pixel wide (see axes). I once had a local patched kig, but I remember the patch was not wanted, and it got lost in the svn->git transition, so I cannot really help where you have to add the offset.

- Christoph Feck


On April 15, 2012, 5:26 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104584/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 5:26 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Pretty straightforward, the question is actually if anybody disagrees. The one issue I would be concerned about is performance, but I would expect this not to be an issue in modern computers, yet I don't have any stress case to test this against.
> 
> 
> This addresses bug 122376.
>     http://bugs.kde.org/show_bug.cgi?id=122376
> 
> 
> Diffs
> -----
> 
>   misc/kigpainter.cpp 18d4396 
> 
> Diff: http://git.reviewboard.kde.org/r/104584/diff/
> 
> 
> Testing
> -------
> 
> Compare drawing a large circle with and without this patch to see antialiasing in action.
> 
> 
> Screenshots
> -----------
> 
> Antialiased
>   http://git.reviewboard.kde.org/r/104584/s/535/
> Aliased
>   http://git.reviewboard.kde.org/r/104584/s/536/
> Antialiased Heptagonal Tessellation
>   http://git.reviewboard.kde.org/r/104584/s/539/
> Aliased Heptagonal Tessellation
>   http://git.reviewboard.kde.org/r/104584/s/540/
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120720/5ac1c691/attachment-0001.html>