Review Request: Google Code-In Task: Fix Marble Code Checker Issues
Kevin Krammer
krammer at kde.org
Mon Dec 31 14:50:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108048/#review24337
-----------------------------------------------------------
src/plugins/network/kio/KIONetworkPlugin.cpp
<http://git.reviewboard.kde.org/r/108048/#comment18675>
space before the last )
i.e. connect( ... );
remove spaces only from within SIGNAL() and SLOT() macros
- Kevin Krammer
On Dec. 31, 2012, 12:38 p.m., Mayank Madan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108048/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2012, 12:38 p.m.)
>
>
> Review request for KDE Edu and Kevin Krammer.
>
>
> Description
> -------
>
> Google Code-In Task
>
>
> Diffs
> -----
>
> src/plugins/network/kio/KIONetworkPlugin.cpp 3adcaca
> src/plugins/network/qhttp/QHttpNetworkPlugin.cpp fa2dca8
> src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.cpp f09e0b1
> src/plugins/positionprovider/gpsd/GpsdConnection.cpp 24fc783
> src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 39ff9b2
> src/plugins/positionprovider/gpsd/GpsdThread.cpp 6cc015f
> src/plugins/positionprovider/maemo/MaemoPositionProviderPlugin.cpp 00d3e92
> src/plugins/positionprovider/placemark/PlacemarkPositionProviderPlugin.cpp 163f1bf
> src/plugins/positionprovider/qtmobility/QtMobilityPositionProviderPlugin.cpp fe51411
> src/plugins/positionprovider/routesimulation/RouteSimulationPositionProviderPlugin.cpp 29bbb15
> src/plugins/positionprovider/wlocate/WlocatePositionProviderPlugin.cpp 469eafb
> src/plugins/render/navigation/NavigationFloatItem.cpp a8b5ca9
>
> Diff: http://git.reviewboard.kde.org/r/108048/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mayank Madan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121231/bfa74f41/attachment.html>
More information about the kde-edu
mailing list