Review Request: Google Code-In Task: Fix Marble Code Checker Issues

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108037/#review24303
-----------------------------------------------------------



src/plugins/runner/monav/MonavConfigWidget.cpp
<http://git.reviewboard.kde.org/r/108037/#comment18627>

    seems you missed a line :)
    Please normalize this SIGNAL signature as well for consistency with the rest of the file


- Kevin Krammer


On Dec. 30, 2012, 7:23 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108037/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 7:23 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Google Code-In Task
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/hostip/HostipRunner.cpp af70d21 
>   src/plugins/runner/json/JsonParser.cpp 0de0b56 
>   src/plugins/runner/monav/MonavConfigWidget.cpp a9d7dc4 
>   src/plugins/runner/monav/MonavPlugin.cpp b500410 
>   src/plugins/runner/nominatim-reversegeocoding/OsmNominatimReverseGeocodingRunner.cpp 70761cf 
>   src/plugins/runner/open-source-routing-machine/OSRMRunner.cpp 128fbb3 
>   tools/poly2kml/main.cpp f4d3b02 
> 
> Diff: http://git.reviewboard.kde.org/r/108037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121231/6f47babc/attachment.html>