Review Request: Google Code-In: Marble Code Checker Issue Fixes

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107959/#review24068
-----------------------------------------------------------


In general it's good to resolve crazy checks. The "contrib" classes inside the mex directory (e.g. astrolib and planetSat classes) are maybe a bit of an exception: It's third party code that will later on be moved into a 3rdparty/contrib directory. So making changes to the code in this particular case will probably not have a real benefit I'm afraid.

- Torsten Rahn


On Dec. 27, 2012, 7:01 p.m., Geoffrey Mon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107959/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 7:01 p.m.)
> 
> 
> Review request for KDE Edu, Marble and Kevin Krammer.
> 
> 
> Description
> -------
> 
> For http://www.google-melange.com/gci/task/view/google/gci2012/8127209
> 31-40 code checker issues (http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeedu/marble/index.html) fixed
> (mostly pre/postfix increment/decrement issues)
> 
> 
> Diffs
> -----
> 
>   src/lib/NavigationWidget.cpp dbc2717 
>   src/plugins/render/satellites/mex/astrolib.cpp dbd1a86 
>   src/plugins/render/satellites/mex/attlib.cpp c9f5486 
>   src/plugins/render/satellites/mex/planetarySats.cpp d5dfe66 
> 
> Diff: http://git.reviewboard.kde.org/r/107959/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Geoffrey Mon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121227/aba7227e/attachment.html>