Review Request: Polish data/pointer type editing dialogs a bit.

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105921/#review17121
-----------------------------------------------------------


Some small comments
* the dialog is too small to show the full caption
* the next button for "Enter" when the focus is on the name line-edit should not be "Delete" but "Close"
* the new data/pointer type should get a default name, e.g., "Data Type" or "Connection Type"
* "Add Pointer Type"/"Add Data Type" should be more separated to "Delete" since Delete has a semantic meaning for the currently selected type, contrary to the add type action

- Andreas Cord-Landwehr


On Aug. 7, 2012, 9:34 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105921/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 9:34 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Tomaz  Canabrava.
> 
> 
> Description
> -------
> 
> Simplify add data/pointer type dialogs.
>     
>     When adding a new type just focus the name edit,
>     instead of having a line edit just for pre-setting its name.
>     
>     Remove QWidgets as layout elements (use layouts instead).
>     
>     Set buddies in the ui files.
> 
> 
> Diffs
> -----
> 
>   src/Interface/DataTypePage.cpp 050b4fb3582756e19db36fa47b670854ddfcf342 
>   src/Interface/DataTypePage.ui f0593163eca889ea7c34b64cd6ad034dd3d84e53 
>   src/Interface/PointerTypePage.cpp 245710adfa467aaff7b1dfa2e6f8502f7a3f2ce3 
>   src/Interface/PointerTypePage.ui 88a6ff1300fdc2719be6027fb3d1c39776625bdc 
> 
> Diff: http://git.reviewboard.kde.org/r/105921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120808/0e5042ed/attachment.html>