Review Request: KBruch - Bug 192707

[Sebastian Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/#review6507
-----------------------------------------------------------


I applied your 3rd diff against trunk/ in git. It somehow works, but is not perfect yet :-) For example, I would expect that I can only enter primefactors by keyboard, but I can also enter e.g. "8".

Also, it should disable all other keys and only allow the multiplication char (both, x and *).

I expected that the buttons get enabled again as soon as I clear all input I entered by keyboard.

Can you rework the patch? It really looks promising and only a bit is needed to get it out!

Anyway, thanks for contributing!

- Sebastian


On Sept. 12, 2011, 5:03 p.m., Luis Angel Fernandez Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102582/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 5:03 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
> 
> As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.
> 
> 
> This addresses bug 192707.
>     http://bugs.kde.org/show_bug.cgi?id=192707
> 
> 
> Diffs
> -----
> 
>   src/PrimeFactorsLineEdit.h 5e78082 
>   src/PrimeFactorsLineEdit.cpp b71bfba 
>   src/exercisefactorize.h c7d304f 
>   src/exercisefactorize.cpp 48c8874 
> 
> Diff: http://git.reviewboard.kde.org/r/102582/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Angel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110914/1dba728e/attachment.html>