Review Request: Implementing a Coordinate Precision Feature in Kig

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102531/#review6303
-----------------------------------------------------------


Looks good to me (note i have only read the code, not compiled nor tested it). What we need to decide now is what to do with the precission setting:
 * Nothing (i.e. the user has to set it every time)
 * Save it to the file
 * Save it to the global user preferences
 * Save it to the user preferences in a per file basis

What do you think it is the best?

- Albert


On Sept. 6, 2011, 10:29 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102531/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 10:29 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> Try to address the feature request at bug 262694 by implementing a configuration dialog to specify coordinate precision on the document. This patch does not deal with saving that information to a file.
> 
> 
> This addresses bug 262694.
>     http://bugs.kde.org/show_bug.cgi?id=262694
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b0f7d52 
>   kig/kig_document.h 010c71b 
>   kig/kig_document.cc 33e6dd7 
>   kig/kig_part.h bb9b09e 
>   kig/kig_part.cpp e04f97d 
>   kig/kigpartui.rc a420963 
>   misc/coordinate_system.cpp 251010b 
>   misc/kigcoordinateprecisiondialog.h PRE-CREATION 
>   misc/kigcoordinateprecisiondialog.cpp PRE-CREATION 
>   misc/kigcoordinateprecisiondialog.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102531/diff
> 
> 
> Testing
> -------
> 
> Users can choose between default precision handling and specifying one of their own, so test cases are:
> 1. Start the application, draw a point specifying coordinates
> 2. Right click on the point and change coordindates - note the coordinate precision used in the display of the coordinates
> 3. Go to Settings -> Specify Coordinate Precision... and uncheck the option to use default specification
> 4. Use the spin box to set some coordinate precision, then click Ok
> 5. Right click on the point and change coordindates - the coordinate precision should have changed to whatever was specified in Step 4
> 6. Go to Settings -> Specify Coordinate Precision... again - the Use Default checkbox should be unchecked and the spin box should be set to whatever was specified in Step 4
> 7. Either change precision or use the default, and repeat Steps 4 to 6
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110906/9ce86f7e/attachment.html>