Review Request: [Step] Fix "Fit to page" bug to work when world is empty

Commit Hook null at kde.org
Fri Oct 28 12:48:01 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102940/#review7718
-----------------------------------------------------------


This review has been submitted with commit 50358bc51e8973c712f29d2ce0b0f1db113d831a by Shlomo Zaks to branch master.

- Commit Hook


On Oct. 25, 2011, 7:21 p.m., Shlomo Zaks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102940/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 7:21 p.m.)
> 
> 
> Review request for KDE Edu and Patrick Spendrin.
> 
> 
> Description
> -------
> 
> In the current version, If you select the "Fit to page" option from the
> "View" menu when the world is empty (no objects), it jumps to the
> upper-left corner and sets the zoom incorrectly.
> This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   step/worldscene.cc d8d5265 
> 
> Diff: http://git.reviewboard.kde.org/r/102940/diff/diff
> 
> 
> Testing
> -------
> 
> Testing: open Step, and select "View > Fit to page".
> Works fine after the fix
> 
> 
> Thanks,
> 
> Shlomo Zaks
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111028/28c18561/attachment.html>


More information about the kde-edu mailing list