Review Request: Avoid processing parameters if the number of arguments is not met in Text Labels

[Albert Astals Cid]

> On Oct. 2, 2011, 8:02 a.m., David Narváez wrote:
> > Everybody ok with this patch now? I'd very much like to include this fix in next release.

I'll try to review it tomorrow, feeling ultrasick as of now.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102725/#review6993
-----------------------------------------------------------


On Sept. 29, 2011, 4 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102725/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 4 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Changed the finished variable to finish, as I think is the way the code was intended to be. Also fixes the second validation that took place (calling canFinish in the finishPressed method) since first validation happens in the validatePage method of the Arguments page.
> 
> 
> This addresses bug 282913.
>     http://bugs.kde.org/show_bug.cgi?id=282913
> 
> 
> Diffs
> -----
> 
>   modes/label.cc d0c855d 
>   modes/textlabelwizard.cc 0721227 
> 
> Diff: http://git.reviewboard.kde.org/r/102725/diff/diff
> 
> 
> Testing
> -------
> 
> 1) Created a new label
> 2) Introduced a parameter %1
> 3) Clicked Next
> 4) Clicked Finish without specifying a parameter
> 5) Clicked Ok in the error popup
> 
> No crash, no second validation.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111002/c54dd939/attachment.html>