Review Request: Add conjunction to the (default) word types
Frederik Gladhorn
gladhorn at kde.org
Wed Nov 23 14:09:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103192/#review8412
-----------------------------------------------------------
Ship it!
Looks great. Please commit.
- Frederik Gladhorn
On Nov. 22, 2011, 4:41 p.m., Jan Gerrit Marker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103192/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2011, 4:41 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> This patch does two things:
> * Adds conjunction to the list of special word types in the context menu of the word type view
> * Adds conjunction to the default list of word types when creating a new file
>
> I would commit them separately, but the patches are that small that I did load them up together.
>
> Update:
> In order to save and load the word type correctly the patch which is posted at https://git.reviewboard.kde.org/r/103204/ is needed.
>
>
> Diffs
> -----
>
> src/parleydocument.cpp 047b703
> src/vocabulary/wordtypeview.h 24b8a2c
> src/vocabulary/wordtypeview.cpp 1d399b6
>
> Diff: http://git.reviewboard.kde.org/r/103192/diff/diff
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Jan Gerrit Marker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111123/cac90af8/attachment.html>
More information about the kde-edu
mailing list