Review Request: Add conjunction to the kvtml2reader and writer

Frederik Gladhorn gladhorn at kde.org
Wed Nov 23 14:08:26 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103204/#review8411
-----------------------------------------------------------

Ship it!


Ship It!

- Frederik Gladhorn


On Nov. 22, 2011, 4:40 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103204/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2011, 4:40 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This patch adds the word type "conjunction" to the reader and writer for KVTML2. It is needed to save the information which is added in the parley patch I posted recently ( https://git.reviewboard.kde.org/r/103192/ ). I think it is necessary to have this in the library because the conjunction type is also defined in the enumeration which holds the word types the library can handle.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvockvtml2reader.cpp 83cf9af 
>   keduvocdocument/keduvockvtml2writer.cpp 9e26743 
>   keduvocdocument/kvtml2defs.h 18b79bb 
> 
> Diff: http://git.reviewboard.kde.org/r/103204/diff/diff
> 
> 
> Testing
> -------
> 
> It works using this test case:
> Create a new file in parley (the patch I mentioned above needs to be applied), add a conjunction and set the word type, save the file, restart parley and load the file. The type of the conjunction you added is conjunction and the special type of the word type conjunction is conjunction, too.
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111123/04c3affe/attachment.html>


More information about the kde-edu mailing list