Review Request: Fix Kalzium build and cleanup CMake warnings during Kalzium configuration by CMake

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103209/#review8407
-----------------------------------------------------------


This is not the right fix for your problems. It seems like there's a bug in avogadro's cmake-config file, possibly avogadro uses FindQt4 with the QT_USE_IMPORTED_TARGETS flag set and then it generates the config-file with an 'avogadro' target that has QtOpenGL in its link-interface. This causes a target to be created for that and exported. But kalzium does not call FindQt4 itself explicitly and hence does not set the QT_USE_IMPORTED_TARGETS. This causes cmake to not know that the QtOpenGL lib is an external lib.

In addition the cmake-config file from avogadro should put the imported target into a cmake variable and name it differently from the actual target in the avogadro build.

- Andreas Pakulat


On Nov. 23, 2011, 4:19 a.m., Ben Cooksley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103209/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 4:19 a.m.)
> 
> 
> Review request for Build System and KDE Edu.
> 
> 
> Description
> -------
> 
> Currently I cannot build Kalzium, due to the following error message:
> gmake[2]: *** No rule to make target `/usr/lib64/libQtOpenGL.so', needed by `lib/libcompoundviewer.so.4.7.0'.  Stop.
> 
> Combined with some warning output when CMake is run on Kalzium, I determined that the dynamic location of libraries, as is currently done for Avogadro is problematic.
> 
> The patch changes this behaviour so that the path to Avogadro is supplied explicitly.
> It also fixes a linking issue with my system, where Kalzium refuses to link to QtOpenGL as it is not explicitly defined as a dependency.
> 
> 
> Diffs
> -----
> 
>   KalziumConfigureChecks.cmake cef3d45 
>   compoundviewer/CMakeLists.txt b2b7e6c 
>   src/CMakeLists.txt 47ebbd1 
> 
> Diff: http://git.reviewboard.kde.org/r/103209/diff/diff
> 
> 
> Testing
> -------
> 
> Now compiles.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111123/19a146cd/attachment.html>