[kde-edu]: Re: Review Request: Parley: [PATCH] Modifications for dictation option and sound option.

[Massimo Lo Iacono]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6623/
-----------------------------------------------------------

(Updated March 21, 2011, 11:05 p.m.)


Review request for KDE-Edu.


Summary (updated)
-------

Hallo.
I have made modifications for dictation option, sound option and little more stuff.

- Now dictation is an option and not a new mode of practice.
- This option is active with "Written", "Mixed Letters" and "Example Sentence" practices.
- Now the language of dictation practice is the second of the pair languageFrom/languageTo.
- Bug fixed: no entry for word without a sound file.
- There is an option to play sound file of question at the start of practice.
- There is an option to hide text of question.
- Now it's possible control "Flash Cards" practice mode using only Enter key without need to use the mouse.
- I fixed o little annoying change of size of practice box (it's ok in Linux, I don't know in Windows or MacOsX).

I created the patch from the 1224006 revision.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwindow.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwindow.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractwidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractwidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonmodewidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonmodewidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationmodewidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationmodewidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/entryfilter.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/examplesentencebackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flashcardmodewidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flashcardmodewidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/genderbackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifrontend.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicedata.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicemodewidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicemodewidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_mainwindow.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_comparison.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_conjugation.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_flashcard.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_multiplechoice.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_written.ui 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/statustoggle.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/testentrymanager.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/settings/parley.kcfg 1224006 
  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp 1224006 

Diff: http://svn.reviewboard.kde.org/r/6623/diff


Testing
-------

I can successful compile and execute the code with my modifications.


Thanks,

Massimo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110321/52beb368/attachment.htm