Review Request: correct confusing action names in kanagrams shortcuts dialog

Jeremy Paul Whiting jpwhiting at kde.org
Fri Jun 3 15:20:38 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101496/#review3650
-----------------------------------------------------------

Ship it!


Looks good to me.  Thanks for fixing this.

- Jeremy Paul


On June 3, 2011, 7 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101496/
> -----------------------------------------------------------
> 
> (Updated June 3, 2011, 7 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Paul Whiting.
> 
> 
> Summary
> -------
> 
> Kanagram has KStandardAction::prior (Qt::Key_PageUp) and next (Qt::Key_PageDown) for the actions to switch to the previous/next Vocabulary. But due to using KStandardAction::prior() and KStandardAction::next() these actions are labelled "Previous Page" and "Next Page" in the shortcuts dialog.
> Patch renames them to "Previous Vocabulary" and "Next Vocabulary" to make it clear, which action are handled with these shortcuts.
> 
> 
> Diffs
> -----
> 
>   src/kanagram.cpp 97e1e90 
> 
> Diff: http://git.reviewboard.kde.org/r/101496/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110603/c0976fdd/attachment.htm 


More information about the kde-edu mailing list