Review Request: Big memory leaks are gone

[Daniel E. Moctezuma]

> On July 21, 2011, 2:17 a.m., Daniel E. Moctezuma wrote:
> >

I'm not sure why my previous message wants to be invisible... but you can commit your last diff into both master and 4.7 branches (so it can be shipped with KDE 4.7.1) and let the users know someone is working on it (in bugs.kde.org).
Good job, btw.


- Daniel E.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102009/#review4921
-----------------------------------------------------------


On July 20, 2011, 6:09 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102009/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 6:09 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> Remove the big memory leaks that the bug talks about.
> In the path to the resolution, some virtual destructors were added, 
> a class member for the radical map, and
> the use of clear(). Without it, the list items destructors where not called (at least the kDebug that I enabled did not wrote anything).
> And finally, the delete before nullify the pointer and the delete where the pointer is not added to the list.
> 
> 
> This addresses bug 275047.
>     http://bugs.kde.org/show_bug.cgi?id=275047
> 
> 
> Diffs
> -----
> 
>   app/kiten.cpp b403da3 
>   lib/DictEdict/dictfileedict.h 3916149 
>   lib/DictEdict/dictfileedict.cpp f24a492 
>   lib/DictKanjidic/dictfilekanjidic.h 49eed7f 
>   lib/DictKanjidic/dictfilekanjidic.cpp 318890b 
> 
> Diff: http://git.reviewboard.kde.org/r/102009/diff
> 
> 
> Testing
> -------
> 
> Run kiten under valgrind. The big memory leaks are gone. There are now only Qt, fontconfig and kdelibs leaks.
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110721/413d23b9/attachment.htm