Review Request: Big memory leaks are gone

Jaime Torres Amate jtamate at
Wed Jul 20 20:09:43 CEST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated July 20, 2011, 6:09 p.m.)

Review request for KDE Edu.


Albert. You're right in every point. I was totally bewildered. (ofuscado)
Removed all the unwanted changes. Thanks.


Remove the big memory leaks that the bug talks about.
In the path to the resolution, some virtual destructors were added, 
a class member for the radical map, and
the use of clear(). Without it, the list items destructors where not called (at least the kDebug that I enabled did not wrote anything).
And finally, the delete before nullify the pointer and the delete where the pointer is not added to the list.

This addresses bug 275047.

Diffs (updated)

  app/kiten.cpp b403da3 
  lib/DictEdict/dictfileedict.h 3916149 
  lib/DictEdict/dictfileedict.cpp f24a492 
  lib/DictKanjidic/dictfilekanjidic.h 49eed7f 
  lib/DictKanjidic/dictfilekanjidic.cpp 318890b 



Run kiten under valgrind. The big memory leaks are gone. There are now only Qt, fontconfig and kdelibs leaks.


Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the kde-edu mailing list