Review Request: correct confusing action names in kanagrams shortcuts dialog
Commit Hook
null at kde.org
Sat Jul 2 16:10:38 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101496/#review4322
-----------------------------------------------------------
This review has been submitted with commit e2968197cc8626b1618320db47771402a2266de2 by Burkhard Lück to branch master.
- Commit
On June 3, 2011, 7 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101496/
> -----------------------------------------------------------
>
> (Updated June 3, 2011, 7 a.m.)
>
>
> Review request for KDE Edu and Jeremy Paul Whiting.
>
>
> Summary
> -------
>
> Kanagram has KStandardAction::prior (Qt::Key_PageUp) and next (Qt::Key_PageDown) for the actions to switch to the previous/next Vocabulary. But due to using KStandardAction::prior() and KStandardAction::next() these actions are labelled "Previous Page" and "Next Page" in the shortcuts dialog.
> Patch renames them to "Previous Vocabulary" and "Next Vocabulary" to make it clear, which action are handled with these shortcuts.
>
>
> Diffs
> -----
>
> src/kanagram.cpp 97e1e90
>
> Diff: http://git.reviewboard.kde.org/r/101496/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110702/403a293a/attachment.htm
More information about the kde-edu
mailing list