[kde-edu]: Re: Review Request: CMakeLists fix in Kiten

[Albert Astals Cid]

> On Jan. 22, 2011, 11:39 a.m., Albert Astals Cid wrote:
> > You don't need that, you are not supposed to build kiten indenpendently, you are supposed to do it from the kdeedu root. This might change if we move to separate git repos.
> 
> Rebetez Etienne wrote:
>     I might be wrong, but we are moving to separate git repos. (http://community.kde.org/KDE_Edu)
>     The patch looks good to me.
>     
>     Thanks Daniel
>

Yep, just saying that this is *not needed* at the moment to "build without errors" as the patch says.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6403/#review9672
-----------------------------------------------------------


On Jan. 22, 2011, 6:01 a.m., Daniel E. Moctezuma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6403/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2011, 6:01 a.m.)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> This patch adds some missing checking for the KDE4 packages on Kiten as it uses some KDE4 CMake macros as well as including the Minimum CMake version to remove warnings.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kiten/CMakeLists.txt 1216027 
> 
> Diff: http://svn.reviewboard.kde.org/r/6403/diff
> 
> 
> Testing
> -------
> 
> With this patch Kiten will build without errors.
> 
> 
> Thanks,
> 
> Daniel E.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110122/0d7c2931/attachment.htm