[kde-edu]: Review Request: KTouch: Fix for "clear history" bug

Peter Rüthemann peter.ruethemann at gmail.com
Fri Feb 25 23:30:52 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6549/
-----------------------------------------------------------

Review request for KDE-Edu.


Summary
-------

In the current version it's not possible to clear the statistics in the "training statistics" window. Only a part of the statistics was cleared.

Changelog:
- The fix clears the current statistics and refreshes the UI
- The sessions restarts at the current level
- The clearStatistics function has now a parameter. The parameter decides whether a new session should be started or not.

This is my first bug fix. Let me know if I violated some coding rules.

Peter


This addresses bug 149758.
    https://bugs.kde.org/show_bug.cgi?id=149758


Diffs
-----

  /trunk/KDE/kdeedu/ktouch/src/ktouch.h 1222767 
  /trunk/KDE/kdeedu/ktouch/src/ktouch.cpp 1222767 
  /trunk/KDE/kdeedu/ktouch/src/ktouchstatisticsdialog.cpp 1222767 
  /trunk/KDE/kdeedu/ktouch/src/ui/ktouchkeyboardeditordialog.ui 1222767 

Diff: http://svn.reviewboard.kde.org/r/6549/diff


Testing
-------

Works with compiled KTouch.


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110225/ea8d5745/attachment.htm 


More information about the kde-edu mailing list