[kde-edu]: Re: Review Request: Fix for bug 220828: anchor firstly appears at origin of coordinates

[Anne-Marie Mahfouf]

> On Feb. 2, 2011, 10:40 p.m., Alexander Potashev wrote:
> > The fix for anchors, pins and sticks now works. Though the bug still exists for disks, boxes, linear and circular motors.
> > 
> > @kde-edu people: When the patch will be OK (or may be it's already OK?), should I commit it, or may be Step is maintained by someone who is responsible for committing patches?
> > 
> > P.S.: I experienced random freezes, but hope that they are not related to the bug of interest.
> 
> Sebastian Voecking wrote:
>     The other ones can be fixed in the same way. I only missed these earlier. Only softbody does funny things (position=(nan,nan)). But that's not related to the patch at all (it also does this without it). I'll check tomorrow if it's somehow related to this bug.
>     
>     I can now commit it myself, since I got my own SVN access tonight. And I am going to maintain Step myself in the future and just began exploring the code and to get a general idea of it.

@Alexander: Sebastian is taking over maintainship of Step (he is a student in physics and has an excellent C++ knowledge and is experienced in physics simulation software!) Thanks a lot for testing the patches! 
At some point in a few weeks or months we could maybe appeal for testers and do a full day on IRC listing all the problems and cross-checking the bugs, I volunteer to organize it.


- Anne-Marie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6437/#review9796
-----------------------------------------------------------


On Feb. 2, 2011, 6:38 p.m., Sebastian Voecking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6437/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 6:38 p.m.)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> The problem occurs for all type of items. The reason was that it was added to the worldmodel before the correct position was set.
> 
> 
> This addresses bug 220828.
>     https://bugs.kde.org/show_bug.cgi?id=220828
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/step/step/worldmodel.h 1218044 
>   /trunk/KDE/kdeedu/step/step/worldmodel.cc 1218044 
>   /trunk/KDE/kdeedu/step/step/worldgraphics.cc 1218044 
> 
> Diff: http://svn.reviewboard.kde.org/r/6437/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110203/691e2c6a/attachment.htm