[kde-edu]: Re: Review Request: Cantor: no deprecated functions

[Alexander Rieder]

> On Jan. 26, 2011, 5:17 p.m., Alexander Rieder wrote:
> > With this patch applied, all the Actions, that are provided by the CantorPart (like save, zoomIn/out, evaluate etc.) stop appearing in both, the menu and the toolbar.
> > Can you please look into this?
> 
> Alexander Rieder wrote:
>     the problem seems to be, that the cantor_part.rc file is not found (it says "KXMLGUIClient::setXMLFile: cannot find .rc file "cantor_part.rc" for component "cantor" " in the debug output). The problem seems to go away if i change the install directory of cantor_part.rc in the CMakeLists.txt from ${DATA_INSTALL_DIR}/cantorpart to ${DATA_INSTALL_DIR}/cantor but i don't know if this is a proper fix.
> 
> Marco Martin wrote:
>     couldn't anser before, sorry ;)
>     that may be it, since i see that konsole that was also recently ported installs its rc in ${DATA_INSTALL_DIR}/konsole

given that i don't really know why it was installed in its own directory in the first place, and it doesn't seem to break anything, can you change the install dir, and commit this patch? Or should I do it?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6412/#review9732
-----------------------------------------------------------


On Jan. 25, 2011, 4:24 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6412/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2011, 4:24 p.m.)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> this changes the calls to deprected functions in ktabwidget and kpart
> necessary to build under the mobile profile
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/cantor/src/cantor.cpp 1216468 
>   /trunk/KDE/kdeedu/cantor/src/cantor_part.h 1216468 
>   /trunk/KDE/kdeedu/cantor/src/cantor_part.cpp 1216468 
> 
> Diff: http://svn.reviewboard.kde.org/r/6412/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110201/52f2247f/attachment.htm