Review Request: Save declensions gender specific

Jan Gerrit Marker jangerrit at weiler-marker.com
Sun Dec 4 21:50:00 UTC 2011



> On Dec. 4, 2011, 2:25 p.m., Albert Astals Cid wrote:
> > To be honest i'm not happy with breaking files, does kvtml support versioning? Can we just increase the version number so that old files are loaded with the old codepath and new ones are saved with the new one?

I don't know the code well, so I hope that Frederik Gladhorn can comment on this.
>From what I read the library does not support versioning, but I could implement the code in a way that it converts the old files to the new format when an old file is read. I'm not sure, though.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103325/#review8698
-----------------------------------------------------------


On Dec. 4, 2011, 1:50 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103325/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2011, 1:50 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Some languages (Latin, for example) have declensions for adjectives which do not only depend on the number and case but on the gender, too. libkdeedu has an implementation for declensions which does not honor this. This patch corrects that wrong behavior. The change adds an incompatibility to files which were created using the old library. I don't think that there are a lot of files with declensions out there, as for example parley does not have the feature, yet, but if needed I'd try parse old files, too.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvocdeclension.cpp 327c3ed 
> 
> Diff: http://git.reviewboard.kde.org/r/103325/diff/diff
> 
> 
> Testing
> -------
> 
> Works with parley, after finishing the implementation of the declension widget (I'll create another review request in order to get this in).
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111204/4a16253c/attachment.html>


More information about the kde-edu mailing list