Review Request: Handle special cases when drawing lines in Kig

Albert Astals Cid tsdgeos at terra.es
Wed Aug 24 10:38:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102417/#review5981
-----------------------------------------------------------

Ship it!


Seems a sane thing to do. Maybe the same should be done to calcRayBorderPoints? Anyway i am not sure this is the "proper" fix, but if it works for you i do not see why it should not commit. So please commit to 4.7 and master.

- Albert


On Aug. 24, 2011, 4:16 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102417/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2011, 4:16 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> Patch to fix bug 266497, by handling special cases when drawing a line in Kig using C++ standard limits.
> 
> 
> This addresses bug 266497.
>     http://bugs.kde.org/show_bug.cgi?id=266497
> 
> 
> Diffs
> -----
> 
>   misc/common.cpp 1d82d58 
> 
> Diff: http://git.reviewboard.kde.org/r/102417/diff
> 
> 
> Testing
> -------
> 
> After applying this fix, context menu for lines does not hang while drawing the line types.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110824/1392df5a/attachment.html>


More information about the kde-edu mailing list