[kde-edu]: Review Request: Kig: use antialiasing for QPainter

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5444/#review7792
-----------------------------------------------------------


This will make drawing a really lot slower for more complex objects (polygons, loci, for example).
Please don't trade a subjective "looking" with an obective "really slow painting".

- Pino


On 2010-09-25 15:22:37, Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5444/
> -----------------------------------------------------------
> 
> (Updated 2010-09-25 15:22:37)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> This simple patch adds an QPainter::Antialiasing hint for Kig's painter. 
> I think smoothed scene looks much better (actually, IMHO without it scene looks a little ugly) and a bit usablier than previous one (see attached screenshots)
> 
> P.S Looks like Kig is using it's own "reinvented wheel" to paint all objects.
> Why don't Kig use Qt Graphics View framework (QGraphicsView/QGraphicsScene/etc)? What do you think about porting Kig to it? (I know that it is an off-topic for this review request, but I want to know your ideas about it)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kig/misc/kigpainter.cpp 1173923 
> 
> Diff: http://svn.reviewboard.kde.org/r/5444/diff
> 
> 
> Testing
> -------
> 
> Kig from KDE 4.5.1 (tested with Qt 4.7.0) compiles with this patch and works fine.
> 
> 
> Screenshots
> -----------
> 
> Without antialiasing
>   http://svn.reviewboard.kde.org/r/5444/s/509/
> With antialiasing
>   http://svn.reviewboard.kde.org/r/5444/s/510/
> With antialiasing (but not for axis&grid)
>   http://svn.reviewboard.kde.org/r/5444/s/513/
> 
> 
> Thanks,
> 
> Igor
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20100925/25bdc665/attachment-0001.htm